chainer / onnx-chainer

Add-on package for ONNX format support in Chainer
MIT License
85 stars 24 forks source link

Reset inputs after exported for out_grad #238

Closed disktnk closed 4 years ago

disktnk commented 4 years ago

then got

inputs = (array([[[[0., 0., 0., ..., 0., 0., 0.],
         [0., 0., 0., ..., 0., 0., 0.],
         [0., 0., 0., ..., 0., 0., 0....., ..., 0., 0., 0.],
         [0., 0., 0., ..., 0., 0., 0.],
         [0., 0., 0., ..., 0., 0., 0.]]]], dtype=float32))

    def forward(self, inputs):
        self.retain_inputs((0, 1, 2, 4))
        x, gamma, mean, var, gy = inputs
        expander = self.expander
        xp = backend.get_array_module(x)

        if self.inv_std is None or self.inv_var is None:
            self.inv_var = xp.reciprocal(var + self.eps)
            self.inv_std = xp.sqrt(self.inv_var, dtype=self.inv_var.dtype)

        self.gamma_over_std = gamma * self.inv_std
>       x_hat = _x_hat(x, mean[expander], self.inv_std[expander])
E       TypeError: 'NoneType' object is not subscriptable

This PR fixed unexepected retained variable node by restored hooked inputs.

codecov-io commented 4 years ago

Codecov Report

Merging #238 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   91.37%   91.39%   +0.02%     
==========================================
  Files          24       24              
  Lines        1611     1615       +4     
==========================================
+ Hits         1472     1476       +4     
  Misses        139      139
Impacted Files Coverage Δ
onnx_chainer/export.py 93.28% <100%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b43993f...97c13dc. Read the comment docs.

disktnk commented 4 years ago

/test

pfn-ci-bot commented 4 years ago

Successfully created a job for commit 97c13dc: