chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
50 stars 14 forks source link

feat: DCA parameter validation #5144

Closed j4m1ef0rd closed 2 months ago

j4m1ef0rd commented 2 months ago

Pull Request

Note: This PR is targeting the core DCA PR. Will rebase once its merged.

Closes: PRO-1538

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

j4m1ef0rd commented 2 months ago

As discussed, I will be refactoring this to move the params (including the Fok param) to the swapping pallet so that we do not have separate limits for each chain that need to be updated separately. I will also be changing the 2 DCA parmas to be 1 param: maximum total swap request duration blocks

dandanlen commented 2 months ago

Some weirdness with the dca merge. Will rebase and fix.

dandanlen commented 2 months ago

PR summary is no longer valid btw.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 89.69072% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (f11e5cd) to head (0a918c8). Report is 6 commits behind head on main.

Files Patch % Lines
state-chain/pallets/cf-swapping/src/lib.rs 74% 9 Missing :warning:
state-chain/pallets/cf-ingress-egress/src/lib.rs 74% 5 Missing and 1 partial :warning:
state-chain/custom-rpc/src/lib.rs 40% 3 Missing :warning:
state-chain/runtime/src/lib.rs 0% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5144 +/- ## ====================================== - Coverage 72% 71% -1% ====================================== Files 454 456 +2 Lines 81912 81890 -22 Branches 81912 81890 -22 ====================================== - Hits 58659 57895 -764 - Misses 20151 20923 +772 + Partials 3102 3072 -30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.