Closed j4m1ef0rd closed 2 months ago
As discussed, I will be refactoring this to move the params (including the Fok param) to the swapping pallet so that we do not have separate limits for each chain that need to be updated separately.
I will also be changing the 2 DCA parmas to be 1 param: maximum total swap request duration blocks
Some weirdness with the dca merge. Will rebase and fix.
PR summary is no longer valid btw.
Attention: Patch coverage is 89.69072%
with 20 lines
in your changes missing coverage. Please review.
Project coverage is 71%. Comparing base (
f11e5cd
) to head (0a918c8
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull Request
Note: This PR is targeting the core DCA PR. Will rebase once its merged.
Closes: PRO-1538
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
MaxSwapRequestDurationBlocks
(for DCA) to the swapping pallet.MaxSwapRetryDurationBlocks
(for FoK) to the swapping pallet.update_pallet_config
rpc.MaxSwapRequestDurationSet
MaxSwapRetryDurationSet
event is now emitted from the swapping pallet.SwappingEnvironment
SwappingEnvironment
snapshotMaxSwapRequestDurationBlocks
to validate the swap request DCA paramsMaxSwapRetryDurationBlocks
storage item