chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.

50 stars 14 forks source link

fix: use blake account hasher. #5145

Closed dandanlen closed 2 months ago

dandanlen commented 2 months ago

Pull Request

Closes: PRO-1542

Checklist

Please conduct a thorough self-review before opening the PR.

[x] I am confident that the code works.
[x] I have written sufficient tests.
[x] I have written and tested required migrations.
[x] I have updated documentation where appropriate.

Summary

Use the blake2_128 hasher for affiliate accounts since they can be inserted by untrusted sources.

Doesn't need to be ported to the release branch.

Janislav commented 2 months ago

As discussed, transferred the changes to my PR.

dandanlen commented 2 months ago

Now that i've opened the PR I'm not sure if it's worth merging - can probably be added to #5083...

Would say we can get it in and rebase - smaller PRs etc.

The will just disappear on the rebase. We'd just be adding another commit that will do nothing except add more work (merge conflicts, another migration...).