chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
48 stars 15 forks source link

Feat: charging broker fee per chunk and in USDC #5161

Closed msgmaxim closed 3 weeks ago

msgmaxim commented 1 month ago

Pull Request

Closes: PRO-1540 and PRO-1483

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

The PR is indended to be reviewed by individual commits

Edit: Updated broker fee tests in bouncer. Because all fees are charged in USDC I ended up leaving only a test for one asset (as opposed to all assets). Keeping all assets seems no longer necessary, and wouldn't be trivial (would likely require running the tests sequentially or with multiple broker account).

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.98246% with 28 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (fb4385c) to head (03a5c06). Report is 3 commits behind head on main.

Files Patch % Lines
state-chain/pallets/cf-swapping/src/lib.rs 88% 21 Missing and 5 partials :warning:
state-chain/pallets/cf-swapping/src/tests.rs 99% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5161 +/- ## ====================================== - Coverage 70% 70% -0% ====================================== Files 481 481 Lines 85760 85829 +69 Branches 85760 85829 +69 ====================================== - Hits 60207 60106 -101 - Misses 22286 22452 +166 - Partials 3267 3271 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.