Closed msgmaxim closed 3 weeks ago
Attention: Patch coverage is 92.98246%
with 28 lines
in your changes missing coverage. Please review.
Project coverage is 70%. Comparing base (
fb4385c
) to head (03a5c06
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
state-chain/pallets/cf-swapping/src/lib.rs | 88% | 21 Missing and 5 partials :warning: |
state-chain/pallets/cf-swapping/src/tests.rs | 99% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull Request
Closes: PRO-1540 and PRO-1483
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The PR is indended to be reviewed by individual commits
broker_fee
field fromSwapRequested
toSwapExecuted
(FYI @zoheb391 and @acdibble). Don't think there are any other implications for the product, other than brokers noticing that only their USDC balance is changing.swap_broker_fee_subtracted_from_swap_amount
was mostly a duplicate so I merged it withexpect_earned_fees_to_be_recorded
.Ccm
andRegular
variants from SwapRequestState intoUserSwap
. Didn't really result in code deduplication, but at least we no longer repeat swap parameters (like the newly added broker_fees).Edit: Updated broker fee tests in bouncer. Because all fees are charged in USDC I ended up leaving only a test for one asset (as opposed to all assets). Keeping all assets seems no longer necessary, and wouldn't be trivial (would likely require running the tests sequentially or with multiple broker account).