chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
50 stars 14 forks source link

chore: disable external RPC tests #5165

Closed kylezs closed 2 months ago

kylezs commented 2 months ago

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

We shouldn't be making external calls within unit tests as it introduces an external dependency to our unit tests. These can be left in the repo for easier testing though, as this has proven useful in the past.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71%. Comparing base (4d57fbd) to head (4b05fd9). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5165 +/- ## ====================================== - Coverage 72% 71% -1% ====================================== Files 454 454 Lines 81912 81768 -144 Branches 81912 81768 -144 ====================================== - Hits 58658 57785 -873 - Misses 20153 20917 +764 + Partials 3101 3066 -35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.