Please conduct a thorough self-review before opening the PR.
[x] I am confident that the code works.
[x] I have written sufficient tests.
[x] I have written and tested required migrations.
[x] I have updated documentation where appropriate.
Summary
Added benchmarks for ignore_my_votes and stop_ignoring_my_votes for the simple case. I do benchmark the recheck_contributed_to_consensuses function independently, which is used by the other extrinsic to avoid the complexity of setting up a state of the system where we need to have multiple elections at the same time. We can just reuse the weight and multiply it by the length of the ElectionConsensusHistoryUpToDate storage item. I think that should be good enough for now.
Non-Breaking changes
If this PR includes non-breaking changes, select the non-breaking label. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.
dandanlen
commented
2 months ago
Pull Request
Closes: PRO-1565
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added benchmarks for
ignore_my_votesandstop_ignoring_my_votesfor the simple case. I do benchmark therecheck_contributed_to_consensusesfunction independently, which is used by the other extrinsic to avoid the complexity of setting up a state of the system where we need to have multiple elections at the same time. We can just reuse the weight and multiply it by the length of theElectionConsensusHistoryUpToDatestorage item. I think that should be good enough for now.Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breakinglabel. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.