chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
48 stars 15 forks source link

feat: pool fills rpc subscription #5214

Closed msgmaxim closed 23 hours ago

msgmaxim commented 2 weeks ago

Pull Request

Closes: PRO-1543

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0.81967% with 242 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (70f0440) to head (9d22d36). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/order_fills.rs 0% 121 Missing :warning:
state-chain/custom-rpc/src/lib.rs 0% 107 Missing :warning:
state-chain/runtime/src/lib.rs 0% 0 Missing and 13 partials :warning:
state-chain/pallets/cf-pools/src/lib.rs 50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5214 +/- ## ====================================== - Coverage 70% 70% -0% ====================================== Files 486 487 +1 Lines 86515 86597 +82 Branches 86515 86597 +82 ====================================== - Hits 60771 60567 -204 - Misses 22425 22692 +267 - Partials 3319 3338 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dandanlen commented 4 days ago

@msgmaxim i've added the capability to query storage directly and reverted the change to cf-pools. Let me know what you think.

msgmaxim commented 3 days ago

@msgmaxim i've added the capability to query storage directly and reverted the change to cf-pools. Let me know what you think.

Looks good. Thanks! Let me know if this can be merged (or happy for you to do so).

dandanlen commented 3 days ago

Cool - think I'll rebase it (39 commits behind main) and let CI run once more before merging.

msgmaxim commented 1 day ago

I'm asking @j4m1ef0rd to approve this so it can be merged.