search

chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
48 stars 15 forks source link

fix: change try_from_iter into from_iter_or_default #5219

Closed dandanlen closed 1 week ago

dandanlen commented 2 weeks ago

This makes the fn infallible, and prevents some strange pre/post runtime upgrade effects.

This is a cherry pick of #5218 (release/1.5)

Also needs to be picked to release/1.6

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (7261b99) to head (c3925f6). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
utilities/src/with_std/rpc.rs 0% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5219 +/- ## ====================================== - Coverage 70% 70% -0% ====================================== Files 483 483 Lines 86390 86254 -136 Branches 86390 86254 -136 ====================================== - Hits 60616 60417 -199 - Misses 22491 22549 +58 - Partials 3283 3288 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.