search

chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
48 stars 15 forks source link

fix: decrease broadcast timeout constants for sol and arb #5228

Closed dandanlen closed 1 week ago

dandanlen commented 1 week ago

I decreased it to 2 minutes.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70%. Comparing base (02de20a) to head (47c82c5). Report is 15 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5228 +/- ## ====================================== - Coverage 70% 70% -0% ====================================== Files 483 483 Lines 86390 86254 -136 Branches 86390 86254 -136 ====================================== - Hits 60613 60420 -193 - Misses 22491 22547 +56 - Partials 3286 3287 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kylezs commented 1 week ago

As discussed, we should increase this to 4 minutes, and then decrease the number of retries in the sol retry_rpc.rs to be 5 - which makes the max just over 2 minutes (currently it's just over an hour)

albert-llimos commented 1 week ago

I see that the EVM timeout. Could we reduce that also to 2 or 4 minutes?

kylezs commented 1 week ago

Looks good to merge @dandanlen ?