Closed albert-llimos closed 2 months ago
Attention: Patch coverage is 86.26374%
with 25 lines
in your changes missing coverage. Please review.
Project coverage is 70%. Comparing base (
8fa1f81
) to head (9a73c5b
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'll fix clippy and queue for merge.
This time it's not flakiness, I'm betting it's because we use this type in AwaitingBroadcasts
#[pallet::storage]
pub type AwaitingBroadcast<T: Config<I>, I: 'static = ()> =
StorageMap<_, Twox64Concat, BroadcastId, BroadcastData<T, I>, OptionQuery>;
inside BroadcastData so we require a migration
@albert-llimos you probably have more important things to do before the weekend - feel free to concentrate on other things, someone else can deal with sorting this out.
@albert-llimos you probably have more important things to do before the weekend - feel free to concentrate on other things, someone else can deal with sorting this out.
Thanks, I really doubt I'll have the time for that. At least it's for 1.7 so there's no rush but it'd be great if someone could sort it out at some point :pray:
Closes: PRO-1634
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Use serialized data as the transaction passed to the engine instead of the regular transaction. The regular transaction is quite annoying/difficult to serialize into the raw transaction in case it needs to be broadcasted manually