search

chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
50 stars 14 forks source link

ci: only merge docker image artefacts if there are any 🐛 #5253

Closed chainflip-bot closed 3 weeks ago

chainflip-bot commented 2 months ago

This is an automated cherry-pick of d5d847afd0332bb3e145b261b870172901547344 to release/1.6. Please review and merge if appropriate. Original PR: https://github.com/chainflip-io/chainflip-backend/pull/5251

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70%. Comparing base (9bf8415) to head (4c4d822). Report is 30 commits behind head on release/1.6.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/1.6 #5253 +/- ## =========================================== - Coverage 70% 70% -0% =========================================== Files 481 481 Lines 86269 86269 Branches 86269 86269 =========================================== - Hits 60431 60429 -2 + Misses 22553 22552 -1 - Partials 3285 3288 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kylezs commented 1 month ago

Is this waiting on something or should we just close it, and it'll be included in 1.7?

kylezs commented 3 weeks ago

Closing, as it's clearly not super important as we've done a number of patches without this - the change is in main already ofc. Save adding unnecessary commits to release branch.