Closed syan095 closed 1 week ago
Attention: Patch coverage is 15.78947%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 72%. Comparing base (
8e1619a
) to head (ebe1e0a
). Report is 5 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
state-chain/custom-rpc/src/lib.rs | 20% | 8 Missing :warning: |
state-chain/runtime/src/lib.rs | 0% | 0 Missing and 8 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
I don't think this addresses PRO-1370 as the issue is intended.
Ah, I missed all the conversation in that linear ticket - it was added as a last-minute thing and I should not have been so presumptuous. I will hold off on this until we can get spec locked down.
I'll close this for now, we can come back to it when we have some agreement.
Pull Request
Closes: PRO-1830 Closes: PRO-1370
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Improved the swap_rate_v3 RPC call and runtime API
cf_pool_simulate_swap