chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
52 stars 15 forks source link

chore: imporove `swap_rate_v3` rpc #5430

Closed syan095 closed 1 week ago

syan095 commented 2 weeks ago

Pull Request

Closes: PRO-1830 Closes: PRO-1370

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

Improved the swap_rate_v3 RPC call and runtime API cf_pool_simulate_swap

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (8e1619a) to head (ebe1e0a). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/lib.rs 20% 8 Missing :warning:
state-chain/runtime/src/lib.rs 0% 0 Missing and 8 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5430 +/- ## ====================================== - Coverage 72% 72% -0% ====================================== Files 490 490 Lines 86892 86786 -106 Branches 86892 86786 -106 ====================================== - Hits 62395 62218 -177 - Misses 21563 21626 +63 - Partials 2934 2942 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

syan095 commented 1 week ago

I don't think this addresses PRO-1370 as the issue is intended.

Ah, I missed all the conversation in that linear ticket - it was added as a last-minute thing and I should not have been so presumptuous. I will hold off on this until we can get spec locked down.

dandanlen commented 1 week ago

I'll close this for now, we can come back to it when we have some agreement.