chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
52 stars 15 forks source link

feat: try-state hook for elections pallet #5440

Closed nmammeri closed 1 week ago

nmammeri commented 1 week ago

Pull Request

Closes: PRO-1726

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

This PR adds try-state hook checks to the Elections pallet. For these hooks to be fired up, the try-runtime-cli must be called with --checks all (or at- least try-state). The ci and troubleshooting guide were updated accordingly.

This PR implemented try-state hook only for the Elections pallet, but it was agreed that another issue will be raised to handle try-state hooks in a more generic way and enable it for all other pallets.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 30.00000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (0e02876) to head (ed21d35). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-elections/src/lib.rs 26% 23 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5440 +/- ## ====================================== - Coverage 72% 72% -0% ====================================== Files 490 490 Lines 87000 86916 -84 Branches 87000 86916 -84 ====================================== - Hits 62410 62242 -168 - Misses 21640 21715 +75 - Partials 2950 2959 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: