chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.
52 stars 15 forks source link

test: Solana's delta-based-ingress electoral System #5445

Closed syan095 closed 18 hours ago

syan095 commented 1 week ago

Pull Request

Closes: PRO-1581

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

Added unit tests for the delta based ingress electoral system. Improved the mock system for the tests. Fixed a bug where on revert, on_finalize will cause underflow panic Log a warning on ingress reverts

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (461e23e) to head (ff2e596). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lectoral_systems/blockchain/delta_based_ingress.rs 0% 0 Missing and 1 partial :warning:
...cf-elections/src/electoral_systems/mocks/access.rs 98% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5445 +/- ## ===================================== - Coverage 72% 71% -0% ===================================== Files 494 494 Lines 87706 87627 -79 Branches 87706 87627 -79 ===================================== - Hits 62712 62652 -60 + Misses 22383 22364 -19 Partials 2611 2611 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.