`last_active_epoch` should be `0` instead of None for genesis validators

chainflip-io / chainflip-backend

The Chainflip backend repo, including the Chainflip Node and CFE.

52 stars 15 forks source link

`last_active_epoch` should be `0` instead of None for genesis validators #796

Closed kylezs closed 3 years ago

kylezs commented 3 years ago

Description

Currently ChainflipAccountData.last_active_epoch is None for genesis validators. Genesis validators are active in epoch 0. This should be reflected in the account data.

andyjsbell commented 3 years ago

@kylezs are you sure about this one? I have just added an integration test to cover this case and we do in fact have 0 for last_active_epoch for the genesis validators. Are you seeing this in polka.js?

kylezs commented 3 years ago

Commenting for visibility: Had another look, and discussed with Andy, seems to still exist, the test mock is potentially doing something the live code isn't? Andy is taking a look.

kylezs commented 3 years ago

Fixed in #808