chainguard-dev / osqtool

Automated testing, generation & manipulation of #osquery packs
Apache License 2.0
70 stars 6 forks source link

Add concurrency for Verify #3

Closed Dentrax closed 2 years ago

Dentrax commented 2 years ago

Signed-off-by: Furkan furkan.turkal@trendyol.com

As a first time user of this, I couldn't able to run correctly in first run (it requires osqueryi) and on my second attempt, I noticed logs were a bit verbose. And took almost ~3m.

So this PR contains some UX improvements such as the followings:

Benchmark:

- time make all  115.71s user 50.61s system 110% cpu 2:43.20 total
+ time make all  120.86s user 54.86s system 316% cpu 52.451 total

Logs:

- "..." returned 6 rows within 52.532313381s
+ "..." returned 6 rows within 53s
tstromberg commented 2 years ago

That seems like a solid improvement. Thank you Furkan!