search

chainguard-images / actions

GitHub actions for the chainguard-images
Apache License 2.0
17 stars 22 forks source link

[apko-snapshot] Add support for pushing additional tags #21

Closed priyawadhwa closed 2 years ago

priyawadhwa commented 2 years ago

we can use this for nginx to start tagging the image with the nginx version

Signed-off-by: Priya Wadhwa priya@chainguard.dev

priyawadhwa commented 2 years ago

Hmm it would be nice to avoid adding another input. I think it might be a little confusing to put everything in target-tag, since we use target-tag as a base for generating other tags as well (e.g. target-tag=latest is then used to turn into the latest-20220712 tag).

We could assume that the first tag in the list is the one we want to tag with the date? Or we tag all of them with the date?

I slightly prefer having the additional input just so we don't have to extract a tag from the list for a special case.

amouat commented 2 years ago

Ah, ok. Yeah, that's fine. Maybe it could be named better e.g. "canonical tag", but then we'll have to update everything :)