search

chainguard-images / actions

GitHub actions for the chainguard-images
Apache License 2.0
17 stars 22 forks source link

Change the way we predicate steps #23

Closed mattmoor closed 2 years ago

mattmoor commented 2 years ago

As-is these aren't disabling Snyk for me with:

    - uses: distroless/actions/vul-scans@main
      with:
        registry: ghcr.io
        username: ${{ github.actor }}
        password: ${{ github.token }}
        image: ${{ matrix.ref }}
        RUN_SNYK: "false"

I'm going to try with this change.

mattmoor commented 2 years ago

I have a successful run of this downstream on distroless/static (with snyk disabled) here: https://github.com/mattmoor/static/runs/7367313315?check_suite_focus=true#logs

strongjz commented 2 years ago

Beat me to it. Was going to fix this Monday. Glad you did and tested it.

Lgtm