[Image Request]: keycloak

chainguard-images / images

Public Chainguard Images

https://chainguard.dev/chainguard-images

Apache License 2.0

542 stars 140 forks source link

[Image Request]: keycloak #451

Open tuananh opened 1 year ago

tuananh commented 1 year ago

What software would you like us to add to our image catalog? (one per issue please)

Keycloak https://github.com/keycloak/keycloak

which versions of the containerized software do you need?

No response

Add some justification for why this specific image and versions are important.

Keycloak is a widely popular choice for identity, especially on-premise.
it's a CNCF project.
Wolfi already has Keycloak package.

Few thing to note though:

Keycloak operator (https://github.com/keycloak/keycloak/tree/main/operator) hardcode the kc.sh path to /opt/keycloak/bin/kc.sh in their code so it's sth we need to keep in mind if we want our image to be compatible with official keycloak operator.

dlorenc commented 1 year ago

What software would you like us to add to our image catalog? (one per issue please)

Keycloak https://github.com/keycloak/keycloak

which versions of the containerized software do you need?

No response

Add some justification for why this specific image and versions are important.

Keycloak is a widely popular choice for identity, especially on-premise.

it's a CNCF project.

Wolfi already has Keycloak package.

Few thing to note though:

Keycloak operator (https://github.com/keycloak/keycloak/tree/main/operator) hardcode the kc.sh path to /opt/keycloak/bin/kc.sh in their code so it's sth we need to keep in mind if we want our image to be compatible with official keycloak operator.

Good catch! We typically use the /usr/share/java/ convention instead of /opt, but this seems like a good enough reason to use /opt or symlink for this specific case.

tuananh commented 1 year ago

To be precise, they have a realm import job which uses the same image as the main image.

in that job, they hardcode the path to kc.sh: https://github.com/keycloak/keycloak/blob/main/operator/src/main/java/org/keycloak/operator/controllers/KeycloakRealmImportJob.java#L165

        var runBuild = (keycloak.getSpec().getImage() == null) ? "/opt/keycloak/bin/kc.sh build && " : "";

        var commandArgs = List.of("-c",
                runBuild + "/opt/keycloak/bin/kc.sh import --file='" + importMntPath + getRealmName() + "-realm.json' " + override);

mritunjaysharma394 commented 4 months ago

I think these PRs should fix it