search

chainloop-dev / chainloop

Chainloop is an Open Source evidence store for your Software Supply Chain attestations, SBOMs, VEX, SARIF, CSAF files, QA reports, and more.
https://docs.chainloop.dev
Apache License 2.0
366 stars 27 forks source link

auto-onboard reusable workflow issue #961

Open migmartri opened 3 months ago

migmartri commented 3 months ago

Two issues

Job doesn't seem to fail if the workflow can't be created

Wrong workflow name

With a configuration like this one, I get the following error

  onboard_workflow:
    name: Onboard Chainloop Workflow
    uses: chainloop-dev/labs/.github/workflows/chainloop_onboard.yml@4173e015dbd5dc2a8802555c268da63d57bbe576
    with:
      project: "chainloop-platform"
      workflow_name: "chainloop-platform-backend-release-production"
    secrets:
      api_token: ${{ secrets.CHAINLOOP_TOKEN }}
ERR failed to create workflow: rpc error: code = InvalidArgument desc = validation error: "chainloop-platform-chainloop-platform-backend-release-production": must be no more than 63 characters

it seems that for some reason the workflow_name I provided gets prepended by the project name. To me that's unexpected since I provided the name explicitly.

migmartri commented 3 months ago

It's very strange, I can't reproduce it using the CLI and the provided information and code seems correct, cc/ @jiparis