Closed filoozom closed 6 years ago
The definition of the function is buf.readUInt32BE(offset)
, not buf.readUInt32BE([offset])
, which is why I decided to go with 0
instead of nothing at all. Who knows, maybe Node 11 or 12 will throw an error on undefined
too 😛
Merged! Thanks for the find and the fix @filoozom !
Maybe I'm missing something here, but an offset of 0 should work. As stated in #23:
A buffer obviously can't be an integer offset, right? I'm quite surprised that it worked on Node 8. In any case, it doesn't in Node 10 anymore.