Closed serdarozturk closed 4 years ago
Thanks for this PR. While this provides some good functionality I'd like to see it be a bit more full featured before we merge something like this in.
cc: @filoozom
Some suggestions:
pkg
command, similar also to the CLI tool.--eth-tnt-addr
arg, which should do validation on that address to ensure that it is a valid address. It should normalize the address to lower case.--public-uri
arg, which should do validation to ensure that this arg is composed of a full URI (not just the IP) and that it is a valid URI that can be parsed. If should also ensure that the host portion of the URI is an IPv4 IP address that is routable (no private IPs allowed)..env
file following the rules for setting the environment variables in that file.--auth-key
arg, and if provided it should write a file to the keys
dir in the form of ETH-ADDRESS.key
and the value should be the value of this auth key arg. The auth key should be validated to be the proper length and only contain hex values.Once created, and packaged as a no-dependency binary, this command line tool should be able to be pulled down into another context with a simple wget/curl of a single file.
If either you or @filoozom are interested in continuing on this I'd be happy to setup a new repo for this, or talk through the details of usage and packaging with you.
Thanks!
I'd gladly pick this up if @serdarozturk doesn't want to. Send me the link to the new repo once it's set up. 😉
By the way, here's the repo for the CLI if someone has comments: https://github.com/filoozom/chainpoint-node-cli.
Thanks. We've incorporated this idea into our new init process.
make easy-setup
no need to edit with vim or nano.