search

chains-project / dirty-waters

automatically detect software supply chain smells and issues
MIT License
5 stars 0 forks source link

feat: add nix flake #13

Closed randomicecube closed 5 hours ago

randomicecube commented 19 hours ago

Adding a Nix flake to the repo -- for now, it'll read the requirements.txt file and create an environment accordingly. Future versions could, for example, include openJDK, for when Java support is developed, and so on.

randomicecube commented 19 hours ago

@Stamp9 Could you confirm whether every single dependency mentioned in requirements.txt is used? I'm asking because, for the flake to (currently) work, I commented out 4 packages which aren't in nixPkgs, ran the example script in the README (for MetaMask) and it worked. As such, I think we should investigate whether every single dependency here is needed, and remove the ones which aren't

BTW, I'll add back soon the assertion of python package versions in the flake, after we know every python dependency which is effectively needed (and their versions)

Stamp9 commented 8 hours ago

@Stamp9 Could you confirm whether every single dependency mentioned in requirements.txt is used? I'm asking because, for the flake to (currently) work, I commented out 4 packages which aren't in nixPkgs, ran the example script in the README (for MetaMask) and it worked. As such, I think we should investigate whether every single dependency here is needed, and remove the ones which aren't

BTW, I'll add back soon the assertion of python package versions in the flake, after we know every python dependency which is effectively needed (and their versions)

Hi, @randomicecube, thanks for checking! I re-generate the requirements.txt by using pipreqs, feel free to check and make modification!

randomicecube commented 5 hours ago

@Stamp9 should be fine now, thanks!

monperrus commented 3 hours ago

👍