search

chains-project / maven-lockfile

Lockfiles for Maven. Pin your dependencies. Build with integrity.
MIT License
30 stars 9 forks source link

Make metadata environment section optional on the lockfile #870

Closed massimeddu-sj closed 1 week ago

massimeddu-sj commented 1 week ago

Please introduce a parameter on the plugin to enable/disable the metadata.

We currently have different developers that are running on different environments (with different jvms). Currently the lockfile is updated every time another developer generate the lockfile because the environment is changed.

We would like to have a parameter includeEnvironment that permits to enable/disable the generation of the environment metadata (as we have a parameter to disable the generation of the mavenPlugins data).

The default behavior should be the current one (includeEnvironment=true), so no breaking changes are introduced.

massimeddu-sj commented 1 week ago

Hi @monperrus please have a look at the proposed PR https://github.com/chains-project/maven-lockfile/pull/871 to add this functionality. Please let me know what do you think about. Thank you!

LogFlames commented 1 week ago

Merged with #871

massimeddu-sj commented 3 days ago

Hi @LogFlames @monperrus do you have an expected date on when these changes will be released?

My team is currently relying on an internal fork with these patches, so I would like to know if an when a release is planned, so I can migrate back from the fork to the main project.

Thank you.

LogFlames commented 3 days ago

I will look to create a release ASAP as I see no need to delay. This will however be the first release i publish, so it might take some time to initialize all accounts and for me to get the workflow running.

monperrus commented 2 days ago

thanks @LogFlames https://github.com/LogFlames