chainside / btcnodejs

A Nodejs SegWit-compliant library which provides tools to handle Bitcoin data structures in a simple fashion.
https://www.chainside.net
GNU Lesser General Public License v3.0
37 stars 13 forks source link

Use Integer for deserialized Output #4

Closed nikolai-b closed 6 years ago

nikolai-b commented 6 years ago

readInt64 returns a Long https://github.com/dcodeIO/bytebuffer.js/blob/fbefed78513615946731c059e2597732adde0d97/externs/bytebuffer.js#L405

nikolai-b commented 6 years ago

I've updated this so it applies cleanly. Do you want me to add a test? It is covered in the current testing but because Long behaves like a number it already passes.

d0ze commented 6 years ago

Sorry for taking so long, i've been busy with some other work and i missed to review the pr. I'm going to merge it asap