search

chaintip / bounties

A list of the ChainTip bounties available
http://www.chaintip.org/github#tip-issue
26 stars 5 forks source link

[dagurval/doublespend.cash]: Visualization of txids missing a character #29

Open chaintip opened 6 years ago

chaintip commented 6 years ago

Repository: dagurval/doublespend.cash Issue #1: Visualization of txids missing a character

In Flowee I have double-spend detection as well, which is needed for some other components like a point-of-sale solution build on Flowees APIs. So when I noticed this in my logs today I thought I'd check if we got the same data; 16:17:54 [2501] Double spend found b86a8a170b55ebb516dd5dde036b85b4acea25a26de8e83ee0764757ec94c851 acb4eb8a07b6124fe14903bed92ce653081f0e0ca439a2d983154609e3fb3ceb·

I noticed that the '1' and the 'b' were missing at the end of your version of events. But the clickable link has it, so its purely a minor rendering issue.

(Thanks for the report @zander)

This is possibly off-by-one error in https://github.com/dagurval/doublespend.cash/blob/master/respend/websitebuilder.py#L128

@chaintip 120 days

Total Bounty: 0 BCH| ~ 0.00 USD

To claim this bounty, get a pull request merged with @chaintip fixes #1 in the creation comment.

Returned Tips:

chaintip commented 6 years ago

What should the behaviour be in this case @dargurval? If a funded issue is closed without being fixed by a PR then all the tips to the issue are sent back to their tippers immediately? Can you think of any situation/s where this behaviour would not be desirable?

DJMcNab commented 6 years ago

Personally, I think that Chaintip should have a time after closing without the tip being sent back, say 5 days, to disincentivise someone making the tip then removing it when they get a PR. That would also stop a mistake if the issue was closed accidentally (and reopened 30 seconds later). Chaintip should probably make a comment when the issue closes explaining this

Also, you mispelt @dagurval. Any better ideas?

chaintip commented 6 years ago

That sounds reasonable. Thanks. Thanks for calling @dagurval :) Will wait on his opinion too as he uses this service the most so far.

DJMcNab commented 6 years ago

Just another point while you're here - should the bounties where all the tips have been returned be removed/moved into a different section - at the moment there are 7 where that has happened. It makes it look like it's quite buggy, although it seems to be very good from what I've seen of it.

dagurval commented 6 years ago

Sounds good to me. Return tip after n days of issue being closed if it isn’t reopened.

Most importantly remove it from the open bounties list so no one begins work on it.

I think 5 days is a bit short.

zander commented 6 years ago

I noticed that the readme still lists this bounty. Maybe this issue should be renamed or closed or something to avoid the script from picking it up?

chaintip commented 6 years ago

@zander I was hoping to leave this bounty as a test case for when I fix the logic for closing bounties.