search

chaintope / bitcoinrb

The implementation of the bitcoin protocol for ruby.
MIT License
61 stars 19 forks source link

Extract method to convert int to even-length hex #17

Closed quanon closed 6 years ago

quanon commented 6 years ago

I found there're some ways to convert integer to even-length hex string, so I extracted a method to do that.

azuchi commented 6 years ago

LGTM.

Only one point, bitcoinrb implements a similar extension using open class. Can you match it because it's just different from here alone?

quanon commented 6 years ago

Can you match it because it's just different from here alone?

Certainly 👍