search

chaintope / bitcoinrb

The implementation of the bitcoin protocol for ruby.
MIT License
61 stars 19 forks source link

Fix method comment. #21

Closed Yamaguchi closed 6 years ago

Yamaguchi commented 6 years ago

Fix method comment.

Account#create_receive and Account#create_change don't return Bitcoin::ExtKey that its comment says.(but return Bitcoin::ExtPubkey)

irb(main):007:0> wallet = Bitcoin::Wallet::Base.create(99999)
=> #<Bitcoin::Wallet::Base:0x000000010c0005c0 @path="/Users/h_yamaguchi/.bitcoinrb/mainnet/db/wallet/wallet99999/", @db=#<Bitcoin::Wallet::DB:0x000000010c000548 @level_db=<LevelDB::DB "/Users/h_yamaguchi/.bitcoinrb/mainnet/db/wallet/wallet99999/">, @master_key=#<Bitcoin::Wallet::MasterKey:0x000000010bf90ba8 @mnemonic=["job", "improve", "casino", "original", "scale", "wonder", "lady", "jeans", "catch", "robot", "weasel", "endorse", "chaos", "science", "column", "crash", "copper", "price", "siege", "token", "gap", "zone", "easily", "jealous"], @seed="6f09e93432c3afbb144c554a98ded8eeb2227db66e601e9b528f82f90235733a0aa5f3a131fd3745f61491da2a57386c61b367365343930be50bcca9853c144a", @encrypted=false, @salt="">>, @wallet_id=99999>
irb(main):008:0> account = wallet.accounts.first 
=> #<Bitcoin::Wallet::Account:0x000000010bf94618 @purpose=84, @index=0, @name="Default", @receive_depth=0, @change_depth=0, @lookahead=10, @account_key=#<Bitcoin::ExtPubkey:0x000000010bf94c30 @depth=3, @number=2147483648, @parent_fingerprint="abf3280e", @chain_code="\xC7\x05\xFD\x02\x97L>&V\xF8Ue\b32a\x16\x18\n\x0E4z\xD7.l\x9E/\x04\xD2\x90P\xD3", @pubkey="02687a6cf999982ab90389fd22ed2cbb36e1ec24a255f431e0415b6e15ff98d763", @ver="04b24746">, @wallet=#<Bitcoin::Wallet::Base:0x000000010c0005c0 @path="/Users/h_yamaguchi/.bitcoinrb/mainnet/db/wallet/wallet99999/", @db=#<Bitcoin::Wallet::DB:0x000000010c000548 @level_db=<LevelDB::DB "/Users/h_yamaguchi/.bitcoinrb/mainnet/db/wallet/wallet99999/">, @master_key=#<Bitcoin::Wallet::MasterKey:0x000000010bf90ba8 @mnemonic=["job", "improve", "casino", "original", "scale", "wonder", "lady", "jeans", "catch", "robot", "weasel", "endorse", "chaos", "science", "column", "crash", "copper", "price", "siege", "token", "gap", "zone", "easily", "jealous"], @seed="6f09e93432c3afbb144c554a98ded8eeb2227db66e601e9b528f82f90235733a0aa5f3a131fd3745f61491da2a57386c61b367365343930be50bcca9853c144a", @encrypted=false, @salt="">>, @wallet_id=99999>>
irb(main):009:0> account.create_receive
=> #<Bitcoin::ExtPubkey:0x00007f807c0c3d58 @depth=5, @number=1, @parent_fingerprint="f0f7cc02", @chain_code="\\\xE4\xF71p\xA0c\xDF?\x87}K\x13\xCE!g\xF5\xF2&hU\"(v\xF9\x86$\xC0\xE1\t\xBB\xDC", @pubkey="0225872dbd5006383baa29c78a75450002b25991949f509b9557f71f48cf15f9db", @ver="04b24746">
irb(main):010:0> account.create_change
=> #<Bitcoin::ExtPubkey:0x000000010c01af10 @depth=5, @number=1, @parent_fingerprint="7fc78887", @chain_code="\x85\xED0ysa\xCE]M\x18;*\xAF\xD8#\xC1:\xD6\x12\x9Cy\xEA\x0F\xC4\xA6n\xAB\xDC\xD2?\x11|", @pubkey="03417b0bd62c7480a35505c8d6a6f0c64eb6a503253d93a96147f947250d3ca55b", @ver="04b24746">
azuchi commented 6 years ago

thanks!