search

chaintope / tapyrus-signer

Tapyrus Signer reference implementation.
GNU General Public License v3.0
7 stars 8 forks source link

Update setup documents #105

Closed rantan closed 4 years ago

rantan commented 4 years ago

I change the structure of setup.md to be placed as a part of tapyrus-core getting started document. So I also updated tapyrus-core getting started document in a PR. Check it please.

rantan commented 4 years ago

@Yamaguchi

Thanks, I will check it again totally. but i will give you short reply for your comment.

"Aggregate public key" or "aggregated public key"?

I used "Aggregate public key" because tapyrus-core uses this description in documents for consistency. (But i found a case i missed to change.)

Why the words "Aggregate public key" and "Node secret share" start with upper case ?

I just imitated tapyrus-core document. It seems defined as Tapyrus network parameters in the document. So, I should write definitions for Node secret share as a tapyrus-signer parameter too if i use this kind of description.

rantan commented 4 years ago

@Yamaguchi I updated setup.md, federation.md and README.md. Can you check it again?

configuration.md is still old. I'm going to create another PR for updating it.