search

chainwayxyz / citrea-e2e

E2E Test framework for citrea
GNU General Public License v3.0
2 stars 0 forks source link

Implement Node trait for Clementine #3

Open jfldde opened 1 month ago

kalyberk commented 1 month ago

Hey @jfldde, what exactly is needed here? Could you please elaborate further?

jfldde commented 1 month ago

Hey @kalyberk, not too sure about how Clementine will be used. Is it a binary that needs to be spawned ? If yes, we'll need to implement the Node trait on it to handle spawning, starting, cleaning it up, etc. If not, please explain how it should be integrated

ceyhunsen commented 1 month ago

@jfldde it is possible to spawn Clementine servers (operator, verifier and aggregator) using it's single binary or using their spawner functions. Currently no Docker image, though.

@ekrembal and I were talking about this other day: Citrea may not need to spawn Clementine to test it's e2e infrastructure. Because it only moves funds between Citrea and Bitcoin, Citrea doesn't need this functionality to test reliably.

Still, if this is needed I could look into this. It should just look like Citrea's sequencer spawner etc.

kalyberk commented 1 month ago

@jfldde My information base on Clementine is pretty limited, especially regarding the implementation. I believe @ceyhunsen 's assistance on this issue would be more useful than mine, so, I'm de-assigning myself from the issue. Feel free to ask me anything about the bridge backend itself.

ceyhunsen commented 1 month ago

We discussed this issue with @eyusufatik and we will be implementing support for spawning Clementine servers. This repo will have tests that run nightly to check if whole infrastructure works as expected. I will be implementing this whenever I find time.

A new issue probably needs to be opened for these tests but I don't have full details and is a bit early for it. Once we closed all the current issues, we can look into this.