chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
118 stars 24 forks source link

Min relay fee not met error when sequencer ran with bitcoin regtest #1249

Open yaziciahmet opened 2 weeks ago

yaziciahmet commented 2 weeks ago

Summary

When sequencer is ran with bitcoin regtest, and the commitment tx is submitted to bitcoin regtest, an error is returned from DA on test_mempool_accept rpc call: min relay fee not met

Steps to reproduce

  1. Run bitcoin regtest and sequencer
  2. Sequencer creates commitment and finds correct tx prefix
  3. Error is logged: min relay fee not met

Expected Result

Commitment tx is successfully submitted

Additional Info

Checked my mempool config by running bitcoin-cli -regtest getmempoolinfo:

{
  "loaded": true,
  "size": 0,
  "bytes": 0,
  "usage": 48,
  "total_fee": 0.00000000,
  "maxmempool": 300000000,
  "mempoolminfee": 0.00001000,
  "minrelaytxfee": 0.00001000,
  "incrementalrelayfee": 0.00001000,
  "unbroadcastcount": 0,
  "fullrbf": false
}

It seems minrelaytxfee is 1 sat/byte which is our default value, so this shouldn't be the problem.

eyusufatik commented 1 week ago

this is interesting.

you are running regtest with -fallbackfee option, right?

this means there is some errors on our tx size calculation and that results in not enough fees being paid.

however I thought I've fixed this before launching testnet. are you sure you are testing on a current version?