chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup πŸŠπŸ‹
https://citrea.xyz
GNU General Public License v3.0
129 stars 26 forks source link

Reorganize citrea rollup files #1490

Closed rakanalh closed 6 days ago

rakanalh commented 6 days ago

Description

bin/citrea and internal provers are nested more levels that i care for. IMO, the currently suggested reorg of files could improve things a bit.

eyusufatik commented 6 days ago

I like bin/citrea/provers -> guests/

however, I'd like to keep bin/citrea naming. Soon we'll have bin/citrea-l1-syncer for example. We might have different binaries.

What do you think?

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.2%. Comparing base (5df7a06) to head (96d1f5c). Report is 1 commits behind head on nightly.

Files with missing lines Patch % Lines
bin/citrea/src/rollup/bitcoin.rs 0.0% 1 Missing :warning:
Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1490?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz) | Coverage Ξ” | | |---|---|---| | [bin/citrea/src/rollup/bitcoin.rs](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1490?src=pr&el=tree&filepath=bin%2Fcitrea%2Fsrc%2Frollup%2Fbitcoin.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz#diff-YmluL2NpdHJlYS9zcmMvcm9sbHVwL2JpdGNvaW4ucnM=) | `0.0% <0.0%> (ΓΈ)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1490/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz)

🚨 Try these New Features: