chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
129 stars 26 forks source link

Invalidate Soft Confirmation on sov-module errors #1514

Open eyusufatik opened 18 hours ago

eyusufatik commented 18 hours ago

Description

any failing (I don't mean reverting here, failing) evm tx would make the soft confirmation invalid.

The way I handled the hash bug fix should be changed into a better one imo.

At the beginning of the project we thought when we enabled forced transactions we would need to run them along soft confirmations. However, they can be treated differently. All the workaround and ignoring errored transactions makes a lot of stuff much harder. e.g. we have to have weird workaround accessory maps for block bulding etc.

Another goal of this pr is to fix error handling and propogation in the STF

Closes #1438 Closes #1061 (not impl. yet) Closes #1048 (not impl. yet)