search

chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
129 stars 26 forks source link

Carry bitcoin-da tests to e2e #1515

Open yaziciahmet opened 16 hours ago

yaziciahmet commented 16 hours ago

Description

Carry bitcoin-da tests to e2e test framework to avoid needing to maintain mock tx files existing under test_data directory, and being able to properly test all methods.

Linked Issues

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

codecov[bot] commented 7 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.4%. Comparing base (5e5eded) to head (5f5b29d).

Additional details and impacted files | [Files with missing lines](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz) | Coverage Δ | | |---|---|---| | [crates/bitcoin-da/src/helpers/merkle\_tree.rs](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515?src=pr&el=tree&filepath=crates%2Fbitcoin-da%2Fsrc%2Fhelpers%2Fmerkle_tree.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz#diff-Y3JhdGVzL2JpdGNvaW4tZGEvc3JjL2hlbHBlcnMvbWVya2xlX3RyZWUucnM=) | `95.0% <ø> (-0.3%)` | :arrow_down: | | [crates/bitcoin-da/src/helpers/mod.rs](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515?src=pr&el=tree&filepath=crates%2Fbitcoin-da%2Fsrc%2Fhelpers%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz#diff-Y3JhdGVzL2JpdGNvaW4tZGEvc3JjL2hlbHBlcnMvbW9kLnJz) | `80.0% <ø> (+6.0%)` | :arrow_up: | | [crates/bitcoin-da/src/helpers/parsers.rs](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515?src=pr&el=tree&filepath=crates%2Fbitcoin-da%2Fsrc%2Fhelpers%2Fparsers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz#diff-Y3JhdGVzL2JpdGNvaW4tZGEvc3JjL2hlbHBlcnMvcGFyc2Vycy5ycw==) | `92.3% <ø> (+5.7%)` | :arrow_up: | | [crates/bitcoin-da/src/service.rs](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515?src=pr&el=tree&filepath=crates%2Fbitcoin-da%2Fsrc%2Fservice.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz#diff-Y3JhdGVzL2JpdGNvaW4tZGEvc3JjL3NlcnZpY2UucnM=) | `72.7% <100.0%> (+28.3%)` | :arrow_up: | | [crates/bitcoin-da/src/verifier.rs](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515?src=pr&el=tree&filepath=crates%2Fbitcoin-da%2Fsrc%2Fverifier.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz#diff-Y3JhdGVzL2JpdGNvaW4tZGEvc3JjL3ZlcmlmaWVyLnJz) | `48.4% <100.0%> (-37.6%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/chainwayxyz/citrea/pull/1515/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chainwayxyz)