search

chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
125 stars 26 forks source link

Improve TransactionRequest to TypedTransactionRequest conversion #199

Closed eyusufatik closed 1 month ago

eyusufatik commented 8 months ago

In sov-ethereum/src/lib.rs, the conversion from TransactionRequest to TypedTransactionRequest is very ugly and prone to bugs bc of unwraps.

Once corresponding reth issue is resolved update it.

rakanalh commented 2 months ago

Is this still valid?

eyusufatik commented 1 month ago

Once https://github.com/alloy-rs/alloy/pull/183#issuecomment-1928161285 is resolved update it.

tracked in this now https://github.com/alloy-rs/alloy/pull/190

Is this still valid?

yes

eyusufatik commented 1 month ago

sorry this is not valid since we disabled eth_sendTransaction