chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
75 stars 13 forks source link

Testing: Broken DA data in block #689

Open rakanalh opened 3 weeks ago

rakanalh commented 3 weeks ago

Summary

Running test_all_flow with logging shows that the following logs are printed:

2024-06-10T07:17:05.106161Z ERROR FullNode: sov_stf_runner::runner: Found broken DA data in block 0xa8b208cd2beea27a436dab9fbc49a4cad005302693b869c972dafba6ec333da0: Err(Custom { kind: InvalidInput, error: "Unexpected length of input" }). Error: Unexpected length of input
2024-06-10T07:17:05.106213Z ERROR FullNode: sov_stf_runner::runner: Found broken DA data in block 0xa8b208cd2beea27a436dab9fbc49a4cad005302693b869c972dafba6ec333da0: Err(Custom { kind: InvalidInput, error: "Unexpected length of input" }). Error: Unexpected length of input

However, the test passes. We should investigate why this log is being emitted and what's causing it.

Steps to reproduce

  1. Uncomment initialize_logging in test_all_flow
  2. Run test
eyusufatik commented 3 weeks ago

This is due to mock da blocks having "data" instead of transactions, so we always try to parse them. Broken data is [] :)

While implementing #672 we should consider having an array of transactiıons on mock da blocks.

That way we can test stuff we can't right now, like two sequencer commitments on a da block.