search

chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
92 stars 22 forks source link

parse_relevant_inscriptions never checks signature #907

Closed kpp closed 1 month ago

kpp commented 1 month ago

Summary

The signature of a body of an inscription is never checked. And there is a ParserError::IncorrectSignature that is never constructed.

eyusufatik commented 1 month ago

https://github.com/chainwayxyz/citrea/blob/d54cf8354e66cc84832e1f380d5c6fa37e6dd186/crates/bitcoin-da/src/helpers/parsers.rs#L38

It's checked here

eyusufatik commented 1 month ago

see my last comment