chairaudio / SaM-Designer

This fork tries to make compilation a bit less painful and brings JUCE and Faust up to date
1 stars 0 forks source link

github has user issues #1

Open mxa opened 6 years ago

mxa commented 6 years ago

It appears as @Conzar has done commits, not me. Weird. https://github.com/orgs/chairaudio/dashboard

screenshot from 2018-03-12 15-35-07

screenshot from 2018-03-12 15-53-24

mxa commented 6 years ago

@github

Conzar commented 6 years ago

Can you check that its actually me who made those changes? Or could it be somone is using my email?

mxa commented 6 years ago

Oh hi there :) I made the changes. I did not have an email set up for command line commits.

Conzar commented 6 years ago

Oh ok. You can change the commit user to yourself: https://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit

mxa commented 6 years ago

Here is what @github sent me via email support request:

Thanks for reaching out, and sorry to hear of the trouble! Commits being attributed to the wrong user can be caused by a few different things. We've got a help article that details how to resolve the issue here:

https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user

Please let us know if you have any questions or if the steps in that article don't help to clear up the issue.

I think that's a way to say that this is not a bug but a feature. Maybe something to get to know new developers.

Conzar commented 6 years ago

Hi mxa. You will need to change the author on each commit that is linked to my user as described here: https://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit

I don't think there is a way to do this in bulk, so you will have to go through each individual commit.

The email address assigned to those commits is devops@monky-games.com which is owned by me. Maybe the user for those commits is just DevOps and git auto-assigned the devops@monky-games.com email? Either case, you should be able to modify those commits and push them back up to github.

mxa commented 6 years ago

Well obviously I have not been using your email for my commits. From my point of view that is clearly a bug (if not a grave security flaw) in git or @github to match commits from the command line which have no email associated in the local git to some random other github user. That's what happened.

Conzar commented 6 years ago

Hi mxa. Yea, I agree. The user in those commits was DevOps. So github must just auto assign a user based on the closest match to emails. It would be better if github just didn't assign if there is no email address attached to the commits.

mxa commented 6 years ago

I'll try the rebasing when I have a moment of extra time. Not terribly urgent as it doesn't hurt anyone as is. I'll leave this open until then. Nice to meet you @conzar.

Conzar commented 6 years ago

@mxa Nice to meet you as well. All the best!