search

chairemobilite / trRouting

Transit Routing server app using Connection Scan Algorithm and flexible parameters
GNU General Public License v3.0
24 stars 10 forks source link

Use external nlohmann-json library instead of copying the files in th… #279

Closed greenscientist closed 9 months ago

greenscientist commented 9 months ago

…e project

Distro have packages for the json library that we use. Instead of having to maintain a local file in the repo, we will rely on external files on the system.

We changed the #include reference to point the the standard files and added a check in the configure to make sure the file is available. Also updated the github actions to install the right packages and updated the README to add the package to the install instructions

greenscientist commented 9 months ago

For #74

tahini commented 9 months ago

Thanks! looks good, but what happens with Docker?

greenscientist commented 9 months ago

@tahini , I think it was a sync issue. I had a few failure, but the latest build passed correctly when you check docker hub directly. I'll do a this with transition also to check if the Docker build there is also correct with this change.

greenscientist commented 9 months ago

Correct build: https://hub.docker.com/repository/registry-1.docker.io/chairemobilite/trrouting/builds/6980879d-8fea-4794-ba2c-0172e2cb2e3a

greenscientist commented 9 months ago

PR on the Transition side to also update to bookworm: https://github.com/chairemobilite/transition/pull/781