search

chairemobilite / transition

Transition is a modern new approach to transit planning. It's a web application to model, simulate and plan public transit and alternative transportation.
http://transition.city
MIT License
22 stars 13 forks source link

dep: upgrade version of `request-ip` #1002

Closed tahini closed 3 months ago

tahini commented 3 months ago

This removes dependency to is_js, which has a vulnerability issue.

greenscientist commented 3 months ago

Checking the code quickly, I'm wondering if we really need this package...

greenscientist commented 3 months ago

It's used in evolution (look for clientIp), but not in Transition.

tahini commented 3 months ago

I was wondering if it's being used passively by something, like just using it gives some data somewhere, but maybe not.

greenscientist commented 3 months ago

I've looked at the package and it juste add the clientIp field.

tahini commented 3 months ago

ok, on va l'enlever, ça va enlever 2 dépendances au lieu d'une...

tahini commented 3 months ago

C'est fait