users: add a last login time to users

chairemobilite / transition

Transition is a modern new approach to transit planning. It's a web application to model, simulate and plan public transit and alternative transportation.

http://transition.city

MIT License

20 stars 13 forks source link

users: add a last login time to users #877

Closed tahini closed 3 months ago

tahini commented 3 months ago

fixes #876

Add a field: last_login_at to the users table.
Add the recordLogin method to the UserModel to let the model implement recording login. The default implementation does nothing
Set the last login time to the user model based on the users table
Call the recordLogin method in passport strategies whenever there are successful logins.

greenscientist commented 3 months ago

I'm curious, do we want to count API login separatly or not?

tahini commented 3 months ago

I'm curious, do we want to count API login separatly or not?

1- To get the API token, one needs to login with username/password, so this login will be recorded 2- API is just one request, so it won't be considered a log in. But we could record the last token usage date

I'll wait for the API PR to be in before merging this one. There will be conflicts...