chaitjo / personalized-dialog

Code for the paper 'Personalization in Goal-oriented Dialog' (NeurIPS 2017 Conversational AI Workshop)
https://chaitjo.github.io/personalization-in-dialog/
MIT License
132 stars 45 forks source link

Performance issues in the definition of _inference, MemN2N-split-memory/memn2n/memn2n_dialog.py(P1) #12

Closed DLPerf closed 1 year ago

DLPerf commented 3 years ago

Hello, I found a performance issue in the definition of _inference, MemN2N-split-memory/memn2n/memn2n_dialog.py, tf.nn.embedding_lookup(self.A, stories) will be created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

The same issues exist in:

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

chaitjo commented 1 year ago

Sorry, this codebase is not being maintained.