search

chaitu236 / TakServer

Server to handle online TAK games
https://www.playtak.com
GNU General Public License v2.0
35 stars 8 forks source link

Added Ingame chat mode and Square marking. #11

Open TreffnonX opened 8 years ago

TreffnonX commented 8 years ago

Added ingame chat modes and square markers to the server. In both cases, the server uses a game id to identify the game played and distribute the messages either to all clients in a game, or to players only. This will hopefully uncramp the chat in the future.

chaitu236 commented 8 years ago

I'll definitely take the chat feature, but I'm still ambivalent about game marking. The thing is I expect this feature to not be used that much and having this in server code is another potential point of failure (and which would require testing and maintenance after every major code rework). But it might be useful to make videos, etc as you say.

I will need to think this over carefully, and will have to review the code thoroughly. I don't have much time right now owing to semester ending, so I can't work on this or any of the playtak features (unless it is a bug fix) until May 12.

TreffnonX commented 8 years ago

It's also a useful feature to both draw attention to a situation on the board for both players and spectators, not to forget. :) But I see your point. Though you have to admit, this is a total of 90 lines, so not that much new code.

However, focus on your semester. It's more important, I know that. I am just finishing my university deg. too.

Daenyth commented 8 years ago

It seems more appropriate to split the two features into two PRs