chaitu236 / TakWeb

Javascript based Tak client
https://www.playtak.com
GNU General Public License v2.0
39 stars 18 forks source link

layout tweaks #14

Closed 0x70b1a5 closed 8 years ago

0x70b1a5 commented 8 years ago
chaitu236 commented 8 years ago

Thanks for the pull request. But the layout is all messed up. Also, the problem with making text horizontal is that it will take up a lot of space on mobile devices. And the problem with chat width as a % of viewport width is that on mobiles, it'll be too narrow.

0x70b1a5 commented 8 years ago

What percentage of traffic to the site is mobile?

0x70b1a5 commented 8 years ago

Also, it should be possible to show one width for desktop, and another for mobile.

chaitu236 commented 8 years ago

Almost 50% people first visit the site on mobile then quickly switch to desktop (I presume because of the issue https://github.com/chaitu236/TakWeb/issues/13 which prevents chatting on mobiles and also because it is easier to play on a desktop).

It is possible to make width device specific, but a better way would be to enable the user to resize the chat window by dragging the edge.

TreffnonX commented 8 years ago

Not to blunge in, but on my mobile the placement and selection of pieces usually doesn't work. That might also be a reason they switch.

chaitu236 commented 8 years ago

I've seen the issue when changing the window size (either by changing orientation or when trying to chat- in which case the window height is increased to fit virtual keyboard) https://github.com/chaitu236/TakWeb/issues/2. Do you see the issue even without changing window size?

TreffnonX commented 8 years ago

I was never able to figure out what caused it. It sometimes works for a bit. Else I would have reported this.

chaitu236 commented 8 years ago

Ok