search

chaitu236 / TakWeb

Javascript based Tak client
https://www.playtak.com
GNU General Public License v2.0
39 stars 18 forks source link

Refactoring Request: Code Modularization #15

Open TreffnonX opened 8 years ago

TreffnonX commented 8 years ago

Since there are currently at least 3 people working on various forks and branches, and the number might increase in the future, it might be useful to modularize html.index, which is currently the file everything is being done in. This would allow for more flexible modifications, and reduces problems with merging. It also improves control over indicidual changes (for the branch master). Currently almost all variables are stored with board, the rest are directly or indirectly within the top level script. This is practical for quick access, and was probably the way to go in the beginning, but is actually a long term bug hazard.

Suggestion:

chaitu236 commented 8 years ago

I agree there is a lot of tidying up to do. But I don't have time for these large changes for at least 3 weeks.

TreffnonX commented 8 years ago

Give me a shot to do it from your state master. If you don't like it, you can still do it once you get around to it. - Well actually I am just gonna try, and you can decide if its ok. It's just a split for now, no actual refactoring, just a segmentation.

chaitu236 commented 8 years ago

Sure go ahead. But make sure you do only refactoring (and no feature additions) in your branch as it will be easier to verify and merge. On Apr 22, 2016 1:18 PM, "TreffnonX" notifications@github.com wrote:

Give me a shot to do it from your state master. If you don't like it, you can still do it once you get around to it.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/chaitu236/TakWeb/issues/15#issuecomment-213539630

TreffnonX commented 8 years ago

I'm just gonna split it up, no actual lines will change, I might just reorder a few methods to fit into functionality groups. ... well other than the includes of course.

chikamichi commented 8 years ago

What do you plan on using, @TreffnonX ? ES6 modules + browserify?

TreffnonX commented 8 years ago

I was recently unable to take care of this and other issues, due to other stuff that came up for me. I currently have to working method for integration of modularized javascript files. I looked into a python based tool, but I don't like it much, as it seems to have a big overhead for little use. I might look into better options when I find the time. If you have a freeware solution that is easy to set up, I'd take it, but I'd like to merge all files into one, so any kind of server-setup can work it without any addons or plugins. I am not a friend of modifying a webserver to suite a page.