search

chaitu236 / TakWeb

Javascript based Tak client
https://www.playtak.com
GNU General Public License v2.0
39 stars 18 forks source link

Bug: Notation Layout and Move Flashing #36

Open TreffnonX opened 8 years ago

TreffnonX commented 8 years ago

The notation window currently displays the PTN in a reasonably functional way. However some features are provisionary at the moment. The application of moves will flash the board and cause the textures to vanish for a brief moment. Whenever a player makes a move, this will occure too. Also the width of the notation entries will vary depending on the currently displayed move, as well as the size of various entries (Firefox). I have fixes for both in my current Fork, which I can make into a mergable patch on request. See treffnonx.github.io/TakWeb for reference.

These fixes will also make the disabled rendering during move updates obsolete, as the reorganization of pieces does not require an interruption in rendering.

chaitu236 commented 8 years ago

Ah yes, I noticed you fixed it in your branch and was planning to pull your changes. I'll do that in a week when I'm free.

TreffnonX commented 8 years ago

Since I have modulazired index.html into different files, I suspect it will be rather tough to pull without me reintegrating it into the master branch first. Best thing would probably be, if you told me if you want all the notification modifications, or just parts of it. I will then integrate that into the master and start a pull request.

chaitu236 commented 8 years ago

I'll probably modularize also before taking your changes. I'll look at your modularization changes and notification changes before deciding what to take.

TreffnonX commented 8 years ago

I've been looking into compression tools to fold the modularized files into one again, when deploying it on a server. I have not found a tool I like yet. Maybe you will have more success.

chaitu236 commented 8 years ago

I'll take your "Notation Layout and Move Flashing" changes and then modularize my own way. I don't need the notification modifications right now. Could you make a patch against the master branch?

TreffnonX commented 8 years ago

I can make a patch, but I am not home currently, and won't be back til Monday night. Don't wait for me with anyother changes, I'll make it work with whatever is the current state then.

chaitu236 commented 8 years ago

Thank you!