search

chaitu236 / TakWeb

Javascript based Tak client
https://www.playtak.com
GNU General Public License v2.0
40 stars 18 forks source link

Refactor board drawing #50

Closed ghost closed 8 years ago

ghost commented 8 years ago

Started with my previous "StartWithOpponentsPiece". Removed the 'first piece' stuff as per our discussion.

Then did more refactoring of the drawing code, also as per our discussion. I don't particularly care for how large the makeBorders() method is now, but there's not much that can be done about that.

ghost commented 8 years ago

Note, that on an undo I see the letters flashing... but I don't see that in the actual code running on PlayTak. I wonder if my changes have somehow made things less efficient.

I'm fine if you want to hold off on this. I'll investigate. Or maybe you can see what the issue is.

chaitu236 commented 8 years ago

Its alright. When I merge TreffnonX's reset board changes, it would be fixed

TreffnonX commented 8 years ago

Yep, sorry for the delay on that, I have to do some coding for work atm. Will be on it as soon as I am done.

chaitu236 commented 8 years ago

Thats completely alright.

chaitu236 commented 8 years ago

@lachelt There is a regression - the capstone's placement is incorrect on the board

chaitu236 commented 8 years ago

Never mind I fixed it

ghost commented 8 years ago

Thanks.I see that it was sunken into the board. I'm not sure when that crept in. I know it was right at some point after I had done most of the changes.