SAL annotation for some JsRT APIs should be changed.

chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.

MIT License

9.11k stars 1.2k forks source link

SAL annotation for some JsRT APIs should be changed. #1225

Open akroshg opened 8 years ago

akroshg commented 8 years ago

eg. JsSetCurrentContext takes nullptras input but the API annotation has only__In__,so this raises the preFAST error. There are other APIs which have the same behavior. We need to look at other APIs and fix that.

liminzhu commented 8 years ago

Good finding @akroshg! Is there any test mechanism that can help us detect similar issues?

liminzhu commented 8 years ago

If not I can take a manual scan at the headers and check if something is wrong.

dilijev commented 6 years ago

@liminzhu want to take a look?

karikera commented 4 years ago

Why doesn't this apply? It's still making a warning now