chakra 1.11.15 compilation issue

[chenrui333]

Relates to https://github.com/Homebrew/homebrew-core/pull/45033

Trying to ChakraCore from v1.11.13 to v1.11.14, but receiving these errors:

/tmp/chakra-20191009-92499-1eshv12/ChakraCore-1.11.14/lib/Backend/amd64/LinearScanMdA.S:54:34: error: unknown token in expression
    movups xmmword ptr [rax + 80h], xmm0

I wonder if anyone has idea how to get it fixed.

Jenkins build reference: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/49696/version=mojave/console

[MikeHolman]

@pleath @atulkatti FYI

Was this working on 1.11.13? Are you using a new version of Clang? We fixed this in April in our master branch to support Clang 8, but that fix isn't in our 1.11.x release train.

[chenrui333]

@pleath @atulkatti @MikeHolman Any update on this?

[boingoing]

This has been fixed in v1.11.15 if you don't mind moving forward to it.

[chenrui333]

Unfortunately, v1.11.15 also failed. Will trigger a new build today.

[chenrui333]

The error message in my local catalina.

==> ./build.sh --lto-thin --icu=/usr/local/opt/icu4c/include --extra-defines=U_USING_ICU_NAMESPACE=1 -j=8 -y
Last 15 lines from /Users/ruichen/Library/Logs/Homebrew/chakra/01.build.sh:
                ^
/tmp/chakra-20191223-69885-da36fb/ChakraCore-1.11.15/lib/Backend/amd64/LinearScanMdA.S:99:17: error: unknown token in expression
    add rsp, 28h
                ^
/tmp/chakra-20191223-69885-da36fb/ChakraCore-1.11.15/lib/Backend/amd64/LinearScanMdA.S:120:17: error: unknown token in expression
    sub rsp, 28h
                ^
/tmp/chakra-20191223-69885-da36fb/ChakraCore-1.11.15/lib/Backend/amd64/LinearScanMdA.S:125:17: error: unknown token in expression
    add rsp, 28h
                ^
make[2]: *** [lib/Backend/CMakeFiles/Chakra.Backend.dir/amd64/LinearScanMdA.S.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [lib/Backend/CMakeFiles/Chakra.Backend.dir/all] Error 2
make: *** [all] Error 2
See error details above. Exit code was 2

[chenrui333]

my config is as below:

$ brew config
HOMEBREW_VERSION: 2.2.2
ORIGIN: https://github.com/Homebrew/brew
HEAD: 13f508d0dc8ada1726ee09a750285d7447ac3df4
Last commit: 10 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 72cbbbe5e8cdb3f48a507d2f078f89a936d058b6
Core tap last commit: 21 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_DEV_CMD_RUN: 1
HOMEBREW_GITHUB_API_TOKEN: set
CPU: octa-core 64-bit skylake
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
Clang: 11.0 build 1100
Git: 2.24.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
Java: 10, 9.0.1, 1.8.0_232, 1.8.0_211, 1.8.0_152, 1.7.0_222-zulu-7.29.0.5
macOS: 10.15.2-x86_64
CLT: 11.0.33.12
Xcode: 11.3
XQuartz: 2.7.11 => /opt/X11

[chenrui333]

Also tuned the build args a little bit, still failed:

==> ./build.sh --lto --custom-icu=/usr/local/opt/icu4c/include --extra-defines=U_USING_ICU_NAMESPACE=1 -j=8 -y
Last 15 lines from /Users/ruichen/Library/Logs/Homebrew/chakra/01.build.sh:
        movaps xmm1, xmmword ptr [rsp + 10h]
                                           ^
/tmp/chakra-20191223-79297-1ooz054/ChakraCore-1.11.15/lib/Backend/amd64/Thunks.S:80:44: error: unknown token in expression
        movaps xmm2, xmmword ptr [rsp + 20h]
                                           ^
/tmp/chakra-20191223-79297-1ooz054/ChakraCore-1.11.15/lib/Backend/amd64/Thunks.S:81:44: error: unknown token in expression
        movaps xmm3, xmmword ptr [rsp + 30h]
                                           ^
/tmp/chakra-20191223-79297-1ooz054/ChakraCore-1.11.15/lib/Backend/amd64/Thunks.S:83:21: error: unknown token in expression
        add rsp, 40h
                    ^
make[2]: *** [lib/Backend/CMakeFiles/Chakra.Backend.dir/amd64/Thunks.S.o] Error 1
make[1]: *** [lib/Backend/CMakeFiles/Chakra.Backend.dir/all] Error 2
make: *** [all] Error 2
See error details above. Exit code was 2

[chenrui333]

We managed fixed the compilation issue in https://github.com/Homebrew/homebrew-core/pull/45033.

Closing the issue now.