chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.
MIT License
9.13k stars 1.2k forks source link

Use `.editorconfig` to help with code style consistency #6866

Closed ShortDevelopment closed 1 year ago

ShortDevelopment commented 1 year ago

As I am used to using the Visual Studio auto formatter, I always had massiv changes in git, as the default code style does not always match the one used in the CC code base.

Therefore I thought it might be useful having a basic .editorconfig file to let editors like VS know how to format.

One big problem was the placement of the pointer asterisk. The code bases uses different approaches:

One other thing was the indentation in the test *.xml manifest files...

I tried to stick to the CC Coding Conventions.

@rhuanjl What do you think?

rhuanjl commented 1 year ago

I'm happy, merged.